Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] trunk from WordPress:trunk #137

Merged
merged 2 commits into from
Jan 4, 2025
Merged

[pull] trunk from WordPress:trunk #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50d2e06
StoryBook: Add Story for ResolutionTool (#68292)
im3dabasia Jan 4, 2025
3416bf4
Site Editor: fix "Quick Edit Mode" E2E tests (#68484)
t-hamano Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 52 additions & 2 deletions packages/block-editor/src/components/resolution-tool/stories/index.story.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,59 @@ export default {
title: 'BlockEditor/ResolutionControl',
component: ResolutionTool,
tags: [ 'status-private' ],
parameters: {
docs: {
canvas: { sourceState: 'shown' },
description: {
component:
'A control for selecting image resolution with preset size options.',
},
},
},
argTypes: {
panelId: { control: false },
onChange: { action: 'changed' },
value: {
control: { type: null },
description: 'Currently selected resolution value.',
table: { type: { summary: 'string' } },
},
onChange: {
action: 'onChange',
control: { type: null },
description: 'Handles change in resolution selection.',
table: {
type: { summary: 'function' },
},
},
options: {
control: 'object',
description: 'Array of resolution options to display.',
table: {
type: { summary: 'array' },
},
},
defaultValue: {
control: 'radio',
options: [ 'thumbnail', 'medium', 'large', 'full' ],
description: 'Default resolution value.',
table: {
type: { summary: 'string' },
},
},
isShownByDefault: {
control: 'boolean',
description:
'Whether the control is shown by default in the panel.',
table: {
type: { summary: 'boolean' },
},
},
panelId: {
control: { type: null },
description: 'ID of the parent tools panel.',
table: {
type: { summary: 'string' },
},
},
},
};

Expand Down
4 changes: 2 additions & 2 deletions test/e2e/specs/site-editor/page-list.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ test.describe( 'Page List', () => {
await page.getByRole( 'button', { name: 'Layout' } ).click();
await page.getByRole( 'menuitemradio', { name: 'Table' } ).click();
const privacyPolicyCheckbox = page.getByRole( 'checkbox', {
name: 'Select Item: Privacy Policy',
name: 'Privacy Policy',
} );

await privacyPolicyCheckbox.check();
Expand Down Expand Up @@ -352,7 +352,7 @@ test.describe( 'Page List', () => {
// page,
// } ) => {
// const samplePage = page.getByRole( 'checkbox', {
// name: 'Select Item: Sample Page',
// name: 'Sample Page',
// } );

// await samplePage.check();
Expand Down
Loading