Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bytes endpoints returns ArrayBuffer #26

Merged
merged 1 commit into from
Dec 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .fernignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,9 @@ src/index.ts

src/core/websocket
src/serialization/resources/tts/types/OutputFormat.ts

# arraybuffer
src/api/resources/tts/client/Client.ts
src/api/resources/voiceChanger/client/Client.ts
src/core/fetcher/Fetcher.ts
src/core/fetcher/getResponseBody.ts
6 changes: 3 additions & 3 deletions src/api/resources/tts/client/Client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ export declare namespace Tts {
export class Tts {
constructor(protected readonly _options: Tts.Options = {}) {}

public async bytes(request: Cartesia.TtsRequest, requestOptions?: Tts.RequestOptions): Promise<stream.Readable> {
const _response = await (this._options.fetcher ?? core.fetcher)<stream.Readable>({
public async bytes(request: Cartesia.TtsRequest, requestOptions?: Tts.RequestOptions): Promise<ArrayBuffer> {
const _response = await (this._options.fetcher ?? core.fetcher)<ArrayBuffer>({
url: urlJoin(
(await core.Supplier.get(this._options.environment)) ?? environments.CartesiaEnvironment.Production,
"/tts/bytes"
Expand All @@ -54,7 +54,7 @@ export class Tts {
contentType: "application/json",
requestType: "json",
body: serializers.TtsRequest.jsonOrThrow(request, { unrecognizedObjectKeys: "strip" }),
responseType: "streaming",
responseType: "arraybuffer",
timeoutMs: requestOptions?.timeoutInSeconds != null ? requestOptions.timeoutInSeconds * 1000 : 60000,
maxRetries: requestOptions?.maxRetries,
abortSignal: requestOptions?.abortSignal,
Expand Down
6 changes: 3 additions & 3 deletions src/api/resources/voiceChanger/client/Client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export class VoiceChanger {
clip: File | fs.ReadStream | Blob,
request: Cartesia.VoiceChangerBytesRequest,
requestOptions?: VoiceChanger.RequestOptions
): Promise<stream.Readable> {
): Promise<ArrayBuffer> {
const _request = await core.newFormData();
await _request.appendFile("clip", clip);
await _request.append("voice[id]", request.voiceId);
Expand All @@ -60,7 +60,7 @@ export class VoiceChanger {
}

const _maybeEncodedRequest = await _request.getRequest();
const _response = await (this._options.fetcher ?? core.fetcher)<stream.Readable>({
const _response = await (this._options.fetcher ?? core.fetcher)<ArrayBuffer>({
url: urlJoin(
(await core.Supplier.get(this._options.environment)) ?? environments.CartesiaEnvironment.Production,
"/voice-changer/bytes"
Expand All @@ -80,7 +80,7 @@ export class VoiceChanger {
requestType: "file",
duplex: _maybeEncodedRequest.duplex,
body: _maybeEncodedRequest.body,
responseType: "streaming",
responseType: "arraybuffer",
timeoutMs: requestOptions?.timeoutInSeconds != null ? requestOptions.timeoutInSeconds * 1000 : 60000,
maxRetries: requestOptions?.maxRetries,
abortSignal: requestOptions?.abortSignal,
Expand Down
2 changes: 1 addition & 1 deletion src/core/fetcher/Fetcher.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export declare namespace Fetcher {
withCredentials?: boolean;
abortSignal?: AbortSignal;
requestType?: "json" | "file" | "bytes";
responseType?: "json" | "blob" | "sse" | "streaming" | "text";
responseType?: "json" | "blob" | "sse" | "streaming" | "text" | "arraybuffer";
duplex?: "half";
}

Expand Down
2 changes: 2 additions & 0 deletions src/core/fetcher/getResponseBody.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ export async function getResponseBody(response: Response, responseType?: string)
return response.body;
} else if (response.body != null && responseType === "streaming") {
return chooseStreamWrapper(response.body);
} else if (response.body != null && responseType === "arraybuffer") {
return await response.arrayBuffer();
} else if (response.body != null && responseType === "text") {
return await response.text();
} else {
Expand Down
Loading