-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inspector to account relationship for delegated accounts #1442
Conversation
### Summary > Describe your changes. Adds a security policy. ### Related issues or links > Include links to relevant issues or other pages. - #1438 Credit to https://github.com/falcosecurity/falco/security where I plagiarized the text from. I think it accomplishes what we need it to without introducing heavyweight process that we aren't ready for. Signed-off-by: Alex Chantavy <[email protected]> Signed-off-by: Eryx Paredes <[email protected]>
Signed-off-by: Eryx Paredes <[email protected]>
Signed-off-by: Eryx Paredes <[email protected]>
Signed-off-by: Eryx Paredes <[email protected]>
5281e61
to
9518346
Compare
Signed-off-by: Eryx Paredes <[email protected]>
docs/root/modules/aws/schema.md
Outdated
@@ -192,7 +192,11 @@ Representation of an AWS [Inspector Finding](https://docs.aws.amazon.com/inspect | |||
``` | |||
(AWSInspectorFinding)-[:AFFECTS]->(ECRImage) | |||
``` | |||
- AWSInspectorFinding may be delegated from AWSAccounts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a detail that describes how this is different from the :RESOURCE relationship?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, let me add the reference regarding delegated accounts and their findings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While trying to document this clearly I noticed that DELEGATE
was not a great word to describe the relationship and moved it to MEMBER
since it is closer to the definition from AWS: https://docs.aws.amazon.com/inspector/latest/user/admin-member-relationship.html
The delegated administrator can also view and retrieve information for their own account and any associated member.
...
A member account can view and retrieve information about their account in Amazon Inspector, while settings for their account are managed by the delegated administrator.
Signed-off-by: Eryx Paredes <[email protected]>
Summary
Related issues or links
Checklist
Provide proof that this works (this makes reviews move faster). Please perform one or more of the following:
If you are changing a node or relationship:
If you are implementing a new intel module: