Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector to account relationship for delegated accounts #1442

Merged
merged 7 commits into from
Jan 20, 2025

Conversation

heryxpc
Copy link
Contributor

@heryxpc heryxpc commented Jan 17, 2025

Summary

Describe your changes.
Add relationship to :AWSAccount and :AWSInspectorFinding when the finding is ingested via a delegated account.

Related issues or links

Include links to relevant issues or other pages.

Checklist

Provide proof that this works (this makes reviews move faster). Please perform one or more of the following:

  • Update/add unit or integration tests.
  • Include a screenshot showing what the graph looked like before and after your changes.
  • Include console log trace showing what happened before and after your changes.

If you are changing a node or relationship:

If you are implementing a new intel module:

@heryxpc heryxpc requested review from achantavy and serge-wq January 17, 2025 01:35
achantavy and others added 4 commits January 16, 2025 19:42
### Summary
> Describe your changes.

Adds a security policy.

### Related issues or links
> Include links to relevant issues or other pages.

- #1438

Credit to https://github.com/falcosecurity/falco/security where I
plagiarized the text from. I think it accomplishes what we need it to
without introducing heavyweight process that we aren't ready for.

Signed-off-by: Alex Chantavy <[email protected]>
Signed-off-by: Eryx Paredes <[email protected]>
Signed-off-by: Eryx Paredes <[email protected]>
Signed-off-by: Eryx Paredes <[email protected]>
@heryxpc heryxpc force-pushed the delegated-inspector-findings branch from 5281e61 to 9518346 Compare January 17, 2025 01:43
@@ -192,7 +192,11 @@ Representation of an AWS [Inspector Finding](https://docs.aws.amazon.com/inspect
```
(AWSInspectorFinding)-[:AFFECTS]->(ECRImage)
```
- AWSInspectorFinding may be delegated from AWSAccounts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a detail that describes how this is different from the :RESOURCE relationship?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let me add the reference regarding delegated accounts and their findings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While trying to document this clearly I noticed that DELEGATE was not a great word to describe the relationship and moved it to MEMBER since it is closer to the definition from AWS: https://docs.aws.amazon.com/inspector/latest/user/admin-member-relationship.html

The delegated administrator can also view and retrieve information for their own account and any associated member.
...
A member account can view and retrieve information about their account in Amazon Inspector, while settings for their account are managed by the delegated administrator.

@heryxpc heryxpc requested a review from achantavy January 17, 2025 23:11
@heryxpc heryxpc merged commit dd1ef5c into master Jan 20, 2025
7 checks passed
@heryxpc heryxpc deleted the delegated-inspector-findings branch January 20, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants