Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention kapp default update strategy flag in faq #774

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

ringerc
Copy link
Contributor

@ringerc ringerc commented Aug 12, 2024

Add mention of the kapp --apply-default-update-strategy flag to the FAQ and the annotation docs.

This would've been helpful to me as it was not immediately obvious how to force kapp to replace resources in case of label conflicts or other issues that prevent patching.

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for carvel ready!

Name Link
🔨 Latest commit fa47ae6
🔍 Latest deploy log https://app.netlify.com/sites/carvel/deploys/66b98ea551c16800089d92c7
😎 Deploy Preview https://deploy-preview-774--carvel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for carvel ready!

Name Link
🔨 Latest commit c9c238d
🔍 Latest deploy log https://app.netlify.com/sites/carvel/deploys/66e24f623f445c00081131fe
😎 Deploy Preview https://deploy-preview-774--carvel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@praveenrewar
Copy link
Member

LGTM! Thank you for the changes @ringerc! Could you please make the changes in older versions as well?

@ringerc
Copy link
Contributor Author

ringerc commented Sep 5, 2024

@praveenrewar How far back, which versions? Do you have a backport script or helper, or just tend to diff, apply, resolve conflicts?

I can do latest-stable. Will update PR.

@praveenrewar
Copy link
Member

I can do latest-stable

That will do. Thank you!

Add mention of the kapp `--apply-default-update-strategy` flag
to the FAQ and the annotation docs.

Backport to latest stable.

Signed-off-by: Craig Ringer <[email protected]>
@ringerc
Copy link
Contributor Author

ringerc commented Sep 12, 2024

@praveenrewar Rebased and backported

Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the change!

@praveenrewar praveenrewar merged commit d967a5c into carvel-dev:develop Sep 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants