Do not error out on denied error for signatures #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joao Pereira <[email protected]>
Signed-off-by: Joao Pereira <[email protected]>
joaopapereira
temporarily deployed
to
TanzuNet Registry Dev e2e
GitHub Actions
Inactive
praveenrewar
approved these changes
Jul 27, 2023
| signatures, err := subject.Fetch(args) | ||
| require.NoError(t, err) | ||
|
|
||
| require.Equal(t, 2, signatures.Length()) |
There was a problem hiding this comment.
(non-blocking) nit: Should we also assert that the 2 signatures are what we are looking for, like the previous test.
joaopapereira
deleted the
do-not-error-out-on-denied-error-for-signatures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #548