adding option for skipping SSL verification when using Git #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethiyash
changed the title
sethiyash
force-pushed
the
kc-skip-tls
branch
from
0b43f4a
to
a438f0d
Compare
There was a problem hiding this comment.
The changes in the PR looks good to me. However, I think the idea was to use the existing dangerousSkipTLSVerify flag available in kapp config, so we need to extend the functionality here
sethiyash
force-pushed
the
kc-skip-tls
branch
2 times, most recently
from
e1470ed
to
3bd38c2
Compare
praveenrewar
reviewed
Jan 9, 2024
There was a problem hiding this comment.
Adding an e2e test with a local gitlab server might be a bit much, but it would be great if we can specify what sort of manual testing has been done. (We follow these steps and create an App which uses local gitlab server)
sethiyash
force-pushed
the
kc-skip-tls
branch
from
7f3c14b
to
cb8f2dd
Compare
sethiyash
force-pushed
the
kc-skip-tls
branch
2 times, most recently
from
97bc262
to
be04933
Compare
sethiyash
force-pushed
the
kc-skip-tls
branch
2 times, most recently
from
57c820a
to
5c7ebfe
Compare
Signed-off-by: sethiyash <[email protected]>
Signed-off-by: sethiyash <[email protected]>
Signed-off-by: sethiyash <[email protected]>
Signed-off-by: sethiyash <[email protected]>
Signed-off-by: sethiyash <[email protected]>
sethiyash
force-pushed
the
kc-skip-tls
branch
from
5c7ebfe
to
0708c18
Compare
praveenrewar
approved these changes
Jan 29, 2024
Signed-off-by: Yash Sethiya <[email protected]>
sethiyash
force-pushed
the
kc-skip-tls
branch
from
0708c18
to
2592666
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#1286
Which issue(s) this PR fixes:
#1286
Fixes #
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: