Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update flag name SkipSSLVerification to DangerousSkipTLSVerify #298

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Update flag name SkipSSLVerification to DangerousSkipTLSVerify #298

merged 1 commit into from
Oct 11, 2023

Conversation

vmunishwar
Copy link
Contributor

@vmunishwar vmunishwar commented Oct 10, 2023 •
edited
Loading

To fix the issue - #260 and update flag name SkipSSLVerification to DangerousSkipTLSVerify
Ref - #265

joaopapereira
joaopapereira approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaopapereira joaopapereira mentioned this pull request Oct 10, 2023
Merged
@kumaritanushree
Copy link
Contributor

LGTM

@vmunishwar vmunishwar merged commit f640a4f into develop Oct 11, 2023
5 checks passed
@vmunishwar vmunishwar deleted the skip_TLS_verify branch October 11, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaopapereira joaopapereira joaopapereira approved these changes

@kumaritanushree kumaritanushree Awaiting requested review from kumaritanushree

Assignees
No one assigned
Labels
None yet
Projects
Carvel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmunishwar @kumaritanushree @joaopapereira