Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change particles to make them look more distinct for people with colorblindness #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

drherobrine
Copy link

There is an issue about the food and waste particles being too similar to tell apart for people with colorblindness, so I made a small fix to help with that.

@MaPePeR
Copy link

MaPePeR commented Aug 16, 2020

There are a lot of weird unnecessary whitespace changes in your PR.

@drherobrine
Copy link
Author

There are a lot of weird unnecessary whitespace changes in your PR.

I don't get what you mean?

@MaPePeR
Copy link

MaPePeR commented Aug 16, 2020

Click on "Files changed" or at the commit.

The commit says you changed the whole file, even though you only changed a few lines.

@friedkeenan
Copy link

My guess is Windows did its newline shenanigans which changed all normal newlines to their weird newlines

@drherobrine
Copy link
Author

My guess is Windows did its newline shenanigans which changed all normal newlines to their weird newlines

Well, I'm running Ubuntu so not sure if that's it

@friedkeenan
Copy link

Maybe the other way around then, Ubuntu changing the weird Windows newlines to normal ones

@BLiu1
Copy link

BLiu1 commented Aug 17, 2020

You should try and fix the line endings to increase your chances of the PR being merged.

@drherobrine
Copy link
Author

@BLiu1 how would I do that?

@FranchuFranchu
Copy link

@drherobrine Make another commit in your repo where you undo the line endings.

@drherobrine
Copy link
Author

Ok, turns out the \r\n got converted to \n somewhere along the way. Should be sorted out now,

@drherobrine drherobrine reopened this Aug 17, 2020
@drherobrine
Copy link
Author

Oops, clicked the wrong button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants