Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken image links #488

Merged
merged 1 commit into from
Jan 19, 2024
Merged

fix broken image links #488

merged 1 commit into from
Jan 19, 2024

Conversation

MatthewCaseres
Copy link
Contributor

@MatthewCaseres MatthewCaseres commented Jan 18, 2024

I couldn't figure out where /auto_examples/images/sphx_glr_plot_capecod_001.png is supposed to be in the repo, but that link is broken so I added a TODO

edit: not sure what is up with the diff on the triangle.ipynb, seems to be a formatting difference. editing in codespaces so maybe like a different version of vscode than previously used idk.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (633d730) 81.91% compared to head (5ef434b) 81.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #488   +/-   ##
=======================================
  Coverage   81.91%   81.91%           
=======================================
  Files          80       80           
  Lines        4706     4706           
  Branches      807      807           
=======================================
  Hits         3855     3855           
  Misses        648      648           
  Partials      203      203           
Flag Coverage Δ
unittests 81.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbogaardt jbogaardt merged commit 9a3f235 into casact:master Jan 19, 2024
3 checks passed
@jbogaardt
Copy link
Collaborator

Thank you yet again @MatthewCaseres!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants