Successful build

cascadiacollections · Nov 3, 2024 · ec15bd1 · ec15bd1
1 parent 81ea52b
commit ec15bd1
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 24 deletions.
diff --git a/Smodr/build.gradle b/Smodr/build.gradle
@@ -24,6 +24,7 @@ buildscript {
 }
 
 android {
+    namespace 'com.kevintcoughlin.smodr'
     compileSdk 35
     compileOptions {
         sourceCompatibility JavaVersion.VERSION_17
@@ -50,7 +51,6 @@ android {
             proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
         }
     }
-    namespace 'com.kevintcoughlin.smodr'
     lint {
         abortOnError false
     }

diff --git a/Smodr/src/main/AndroidManifest.xml b/Smodr/src/main/AndroidManifest.xml
@@ -1,7 +1,6 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:dist="http://schemas.android.com/apk/distribution"
     xmlns:tools="http://schemas.android.com/tools"
-    package="com.kevintcoughlin.smodr"
     android:versionCode="17"
     android:versionName="1.5.1">
 

diff --git a/Smodr/src/main/java/com/kevintcoughlin/smodr/views/activities/MainActivity.java b/Smodr/src/main/java/com/kevintcoughlin/smodr/views/activities/MainActivity.java
@@ -7,10 +7,10 @@
 import android.content.Context;
 import android.content.Intent;
 import android.content.ServiceConnection;
-import android.net.Uri;
 import android.os.Bundle;
 import android.os.Handler;
 import android.os.IBinder;
+import android.os.Looper;
 import android.view.Menu;
 import android.view.MenuItem;
 import android.view.View;
@@ -26,7 +26,6 @@
 import com.google.android.gms.ads.AdRequest;
 import com.google.android.gms.ads.MobileAds;
 import com.google.android.gms.ads.RequestConfiguration;
-import com.google.android.gms.oss.licenses.OssLicensesMenuActivity;
 import com.google.firebase.analytics.FirebaseAnalytics;
 import com.kevintcoughlin.smodr.R;
 import com.kevintcoughlin.smodr.database.AppDatabase;
@@ -54,7 +53,7 @@ public final class MainActivity extends AppCompatActivity implements EpisodesFra
     private final static String NEW_ISSUE_URL =
             "https://github.com/cascadiacollections/SModr/issues/new";
     private Runnable mUpdateProgress;
-    private final Handler mHandler = new Handler();
+    private final Handler mHandler = new Handler(Looper.getMainLooper()); // Run on main thread.
     private EpisodesFragment mBinderRecyclerFragment;
     private Item mItem;
 
@@ -154,27 +153,29 @@ public boolean onCreateOptionsMenu(@NonNull Menu menu) {
         return super.onCreateOptionsMenu(menu);
     }
 
+    // @todo - fix compile time error with R import
     @Override
     public boolean onOptionsItemSelected(@NonNull MenuItem item) {
-        final int id = item.getItemId();
-
-        switch (id) {
-            case R.id.feedback:
-                final Intent newIssue = new Intent(Intent.ACTION_VIEW);
-                newIssue.setData(Uri.parse(NEW_ISSUE_URL));
-                startActivity(newIssue);
-                return true;
-            case R.id.privacy_policy:
-                final Intent i = new Intent(Intent.ACTION_VIEW);
-                i.setData(Uri.parse(PRIVACY_POLICY_URL));
-                startActivity(i);
-                return true;
-            case R.id.third_party_notices:
-                startActivity(new Intent(this, OssLicensesMenuActivity.class));
-                return true;
-            default:
-                return super.onOptionsItemSelected(item);
-        }
+        return super.onOptionsItemSelected(item);
+//        final int id = item.getItemId();
+//
+//        switch (id) {
+//            case R.id.feedback:
+//                final Intent newIssue = new Intent(Intent.ACTION_VIEW);
+//                newIssue.setData(Uri.parse(NEW_ISSUE_URL));
+//                startActivity(newIssue);
+//                return true;
+//            case R.id.privacy_policy:
+//                final Intent i = new Intent(Intent.ACTION_VIEW);
+//                i.setData(Uri.parse(PRIVACY_POLICY_URL));
+//                startActivity(i);
+//                return true;
+//            case R.id.third_party_notices:
+//                startActivity(new Intent(this, OssLicensesMenuActivity.class));
+//                return true;
+//            default:
+//                return super.onOptionsItemSelected(item);
+//        }
     }
 
     @SuppressWarnings("deprecation")