Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create scyther_on_mac.md #43

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Kashish-Gaur13
Copy link
Contributor

detailed instructions to run scyther on mac through the terminal

detailed instructions to run scyther on mac through the terminal
Copy link
Owner

@cascremers cascremers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please check the comments.


3. Add it to the PATH by using the following commands,

“echo >> /Users/kashishgaur/.zprofile”,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we don't want your username here? ~/.zprofile?


“echo >> /Users/kashishgaur/.zprofile”,

“echo 'eval "$(/opt/homebrew/bin/brew shellenv)"' >> /Users/machinename/.zprofile”,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/Users/machinename/ must be wrong. I guess ~/?


“eval "$(/opt/homebrew/bin/brew shellenv)””

Replace “manchinename” with your respective machine name
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@@ -0,0 +1,51 @@
1. Open the Terminal
2. Install Homebrew, the macOS package manager, by running the following command:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest also adding a link to the official homebrew website.


10. Move to the src directory, and run the following command to build scyther on the machine,

“cmake -G "Unix Makefiles" ”
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't just "cmake" (without arguments) work already?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm actually not even sure if cmake is needed at all here, just make seems to work fine.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, simply "cmake" works fine too.
about the second query, it's usually recommended to run 'cmake' before 'make', especially if we use CMake to generate the build system, which is what we are doing. we want to build the system before executing it.
Just to prevent any unnecessary issues, which users might face (if the build environment is not generated correctly), I've chosen to run the 'cmake' command before the 'make' command

@cascremers
Copy link
Owner

I don't think we need to run cmake and make here; I think we can just use ./build.sh in src/ (as in the Ubuntu description) or alternatively even simpler make at the toplevel (without going into src).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants