Updated MSISDN #199
Merged
Updated MSISDN #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eoghanscasey , thanks for these updates! The Asgard example is one of the examples that uses snippets, so these updates should be done in the |
|
This PR's branch should merge in #202 and address the newly raised SHACL validation errors. |
11 tasks
This will make the content regeneration in the next patch easier to read. Signed-off-by: Alex Nelson <[email protected]>
These were done by applying this `sed` script ... ```sed s/"kb:suspect-device-uuid"/"kb:Device-446421ea-6dde-4fd7-8653-3e631ed872f4"/g s/"kb:phone_account1"/"kb:MobileAccount-74b4e46a-bee3-48f7-a5db-a6178d92aa90"/g s/"kb:sms_message1"/"kb:SMSMessage-21b3e39d-772d-47b0-8501-a6945ddbdfcd"/g ``` ... and then using `make ; git diff` to see what other changes remained to be ported. A follow-on patch will regenerate Make-managed files. References: * #196 Signed-off-by: Alex Nelson <[email protected]>
References: * #196 Signed-off-by: Alex Nelson <[email protected]>
|
|
ajnelson-nist
requested changes
Aug 30, 2022
|
Made updates in the /examples/asgard/src/ directory and make regenerated the example. |
kchason
previously approved these changes
Sep 2, 2022
Conflicts were resolved by editing `/examples/asgard/src/asgard-2.json`, then running `make clean && make && make check`.
ajnelson-nist
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated MSISDN representation.