MiskApplication tests should await ServiceManager Healthy

before proceeding

GitOrigin-RevId: 616c6bb2e1520d114759259e2c0285a393942f50

misk/src/test/kotlin/misk/web/health/MiskApplicationHealthServiceTest.kt

@@ -3,6 +3,7 @@ package misk.web.health
 import ch.qos.logback.classic.Level.INFO
 import ch.qos.logback.classic.Logger
 import com.google.common.util.concurrent.AbstractIdleService
+import com.google.common.util.concurrent.ServiceManager
 import com.google.inject.util.Modules
 import jakarta.inject.Inject
 import jakarta.inject.Singleton
@@ -152,6 +153,10 @@ class MiskApplicationHealthServiceTest {
     get(healthReadinessUrl, "health", expectThrowable = ConnectException::class)
     get(healthStatusUrl, "health", expectThrowable = ConnectException::class)
 
+    // Make sure all services are up before proceeding.
+    val serviceManager = miskApplication.injector.getInstance(ServiceManager::class.java)
+    serviceManager.awaitHealthy()
+
     // Health service will start after all running services so allow it to start.
     DelayHealthStart.okToStartUp.countDown()
     sleep(5.seconds.inWholeMilliseconds)

misk/src/test/kotlin/misk/web/shutdown/GracefulShutdownInterceptorTest.kt

@@ -5,6 +5,7 @@ import ch.qos.logback.classic.Logger
 import com.google.common.util.concurrent.AbstractIdleService
 import com.google.common.util.concurrent.Service
 import com.google.common.util.concurrent.Service.State.NEW
+import com.google.common.util.concurrent.ServiceManager
 import jakarta.inject.Inject
 import jakarta.inject.Singleton
 import misk.MiskApplication
@@ -592,6 +593,12 @@ class GracefulShutdownInterceptorTest {
     }
 
     JettyStartedService.startedLatch.await(10, TimeUnit.SECONDS)
+
+    // Now that we know serviceManager is created and running make sure all services are healthy
+    // before proceeding.
+    val serviceManager = miskApplication.injector.getInstance(ServiceManager::class.java)
+    serviceManager.awaitHealthy()
+
     return miskApplication
   }