-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add description for change_bid_public_key
entry point
#1479
add description for change_bid_public_key
entry point
#1479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor edits, otherwise looks good!
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md
Outdated
Show resolved
Hide resolved
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md
Outdated
Show resolved
Hide resolved
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md
Outdated
Show resolved
Hide resolved
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md
Outdated
Show resolved
Hide resolved
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md
Outdated
Show resolved
Hide resolved
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md
Outdated
Show resolved
Hide resolved
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md
Outdated
Show resolved
Hide resolved
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md
Outdated
Show resolved
Hide resolved
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md
Outdated
Show resolved
Hide resolved
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md
Outdated
Show resolved
Hide resolved
Great content, @wojcik91. Are you planning to finish this PR? |
Co-authored-by: Adam Stone <[email protected]>
@ipopescu I apologize for the delay, I must have missed some notifications. The stuff you pointed out is now fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wojcik91, thank you for the updates. Could you please also change all deploys to transactions, including the casper-client command, which should use put-transaction? Please also test it.
Since deploy is deprecated, we are updating all 2.0 documentation to use transaction instead of deploy.
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md
Outdated
Show resolved
Hide resolved
source/docs/casper/operators/becoming-a-validator/change-bid-public-key.md
Outdated
Show resolved
Hide resolved
@ipopescu I removed all references to deploys, but I still have one outstanding issue - the new |
Thanks, @wojcik91. This PR is ready for merging. We are still working on documentation for 2.0, including calling contracts. Let's merge this content and come back to the |
What does this PR fix/introduce?
Adds a page describing the new
change_bid_public_key
entry point of system auction contract