KUBE-440: add e2e test for cluster-controller upgrade #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trojan295
changed the title
aldor007
reviewed
Oct 28, 2024
aldor007
reviewed
Oct 28, 2024
| - name: Build Go binary amd64 | ||
| run: go build -ldflags "-s -w -X main.GitCommit=$GITHUB_SHA -X main.GitRef=$GITHUB_REF -X main.Version=${RELEASE_TAG:-commit-$GITHUB_SHA}" -o bin/castai-cluster-controller-amd64 . | ||
| run: go build -ldflags "-s -w -X main.GitCommit=$GITHUB_SHA -X main.GitRef=$GITHUB_REF -X main.Version=${RELEASE_TAG:-$VERSION_TAG}" -o bin/castai-cluster-controller-amd64 . |
There was a problem hiding this comment.
Why are you using tag instead of sha? Commit SHA allows to build the image for PR
There was a problem hiding this comment.
It's output from git describe --tags.
When I used the image with commit sha, then it was not possible schedule actions, because the cluster-controller was marked as outdated.
added 23 commits
October 28, 2024 16:42
Trojan295
force-pushed
the
KUBE-632/trigger-e2e-tests
branch
from
d0b4d66
to
3d6a0fc
Compare
added 5 commits
October 28, 2024 16:44
aldor007
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working pipeline run for the e2e: https://github.com/castai/cluster-controller/actions/runs/11520875667