KUBE-644: use informers to watch CSRs #154
Conversation
Trojan295
force-pushed
the
kube-644/csr-informer
branch
from
2732a6e
to
8c898b4
Compare
internal/actions/csr/csr.go
Outdated
| } | ||
| }, | ||
| DeleteFunc: func(obj interface{}) {}, |
internal/actions/csr/csr.go
Outdated
| if cert.Approved() { | ||
| continue | ||
| }, | ||
| UpdateFunc: func(oldObj, newObj interface{}) { |
There was a problem hiding this comment.
Do we need both add and updated?
There was a problem hiding this comment.
Good question, in theory reacting just on add should be enough. Will try to remove the update and see how it behaves.
internal/actions/csr/svc.go
Outdated
| go WatchCastAINodeCSRs(ctx, log, h.clientset, c) | ||
| go func() { | ||
| for { | ||
| if err := WatchCastAINodeCSRs(ctx, log, h.clientset, c); err != nil { |
There was a problem hiding this comment.
why infinite loop here? If watch broke informer will handle reconnect. Did you think of other reasons?
There was a problem hiding this comment.
You are right, the informers handle the reconnect logic, but the createInformer and informer.AddEventHandler might fail. In such case we would end up with a running cluster-controller, but without the auto approval working.
If the context is done, then no error is returned and this goroutine quits.
There was a problem hiding this comment.
Can we initialize informer in main func and pass it here? Because if informer can't be created then there is something wrong
There was a problem hiding this comment.
Should be possible, sounds like a good idea
No description provided.