Simplify artifact inspection logic #41
Merged
+132
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
domust
commented
Nov 28, 2024
•
domust
commented
- Removed unnecessary functions
- Added new types and aliases
- Added comments for old types
- Updated error handling and logging
- Calculating digest in advance instead of during layer analysis
- Open config file only once
- Properly communicate what artifact info is and how is it related to config
- Reordered operations to avoid unnecessary error handling (missingImageKey)
- Split inspect into inspectLayers and inspectImage
domust
force-pushed
the
simplify-artifact-inspection-logic
branch
3 times, most recently
from
f264f2e
to
2a795f9
Compare
domust
force-pushed
the
simplify-artifact-inspection-logic
branch
from
2a795f9
to
b398bfe
Compare
samuelvl
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.