Feature/deposit cap api #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieyou
requested changes
Apr 10, 2022
programs/castle-lending-aggregator/src/instructions/update_deposit_cap.rs
Show resolved
Hide resolved
programs/castle-lending-aggregator/src/instructions/update_deposit_cap.rs
Show resolved
Hide resolved
sdk/src/client.ts
Outdated
| ) | ||
| ); | ||
|
|
||
| const txs: SendTxRequest[] = []; |
There was a problem hiding this comment.
Doesn't need to be a list since it is only one tx being sent
charlieyou
requested changes
Apr 12, 2022
| @@ -387,6 +387,23 @@ describe("castle-vault", () => { | |||
| assert.equal(userLpBalance, 0); | |||
| assert.equal(lpTokenSupply, 0); | |||
| }); | |||
|
|
|||
| it("Update deposit cap", async function () { | |||
There was a problem hiding this comment.
Can you add an unhappy-case test that it fails if not signed / signed by wrong person?
charlieyou
requested changes
Apr 12, 2022
tests/castle-lending-aggregator.ts
Outdated
| }); | ||
| testDepositAndWithdrawal(); | ||
| }); | ||
| // describe("Deposit and withdrawal", () => { |
There was a problem hiding this comment.
Can you comment these back in? :)
There was a problem hiding this comment.
yes of course, this was a mistake
tests/castle-lending-aggregator.ts
Outdated
| txs[txs.length - 1], | ||
| "singleGossip" | ||
| ); | ||
| assert.ok(false); |
There was a problem hiding this comment.
assert.fail("Tx succeeded when it should have failed") might be better here.
charlieyou
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added methods for the on-chain program and the client sdk to update the deposit cap.