Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to fusion regression yaml #2619

Open
lintool opened this issue Oct 9, 2024 · 4 comments
Open

Improvements to fusion regression yaml #2619

lintool opened this issue Oct 9, 2024 · 4 comments

Comments

@lintool
Copy link
Member

lintool commented Oct 9, 2024

This is a good starting point:
https://github.com/castorini/anserini/blob/master/src/main/resources/fuse_regression/beir-v1.0.0-robust04.flat.bm25.fuse.bge-base-en-v1.5.bge-flat-onnx.yaml

But I have suggestions for improvements. Instead of:

runs:
  - runs/run.beir-v1.0.0-robust04.flat.bm25.topics.beir-v1.0.0-robust04.test.txt
  - runs/run.beir-v1.0.0-robust04.bge-base-en-v1.5.bge-flat-onnx.topics.beir-v1.0.0-robust04.test.txt

Maybe we can do something like:

runs:
  - name: flat-bm25
    dependency: beir-v1.0.0-robust04.flat.yaml 
    file: runs/run.beir-v1.0.0-robust04.flat.bm25.topics.beir-v1.0.0-robust04.test.txt
  - name: bge
    ...

And down further you can just use ${flat-bm25} so that if the run name changes, you only need to change in one spot?

Happy to discuss if you think otherwise?

@Stefan824
Copy link
Contributor

On it

@lintool
Copy link
Member Author

lintool commented Oct 28, 2024

Initial implementation merged in at #2626

@lintool
Copy link
Member Author

lintool commented Oct 28, 2024

I'd still like the above feature implemented...

Also, if you run this:

python src/main/python/run_fusion_regression.py --regression beir-v1.0.0-robust04

And the input files don't exist, the script should throw an error... and it should ask you to run the dependent regressions.

@Stefan824
Copy link
Contributor

Got it. Caught the flu this week, will work on it next week if it's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants