Onboarding add to reproduction logs #2060
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lintool
reviewed
Jan 14, 2025
docs/conceptual-framework.md
Outdated
| + Results reproduced by [@nourj98](https://github.com/nourj98) on 2025-01-07 (commit [`6ac07cc`](https://github.com/castorini/pyserini/commit/6ac07ccfa864220022722f328e074b9078bdb122)) | ||
| + Results reproduced by [@Alexisfine](https://github.com/Alexisfine) on 2025-01-13 (commit [`2efa322`](https://github.com/Alexisfine/pyserini/commit/2efa322e3dc5e947aeaedbc729956821fa09b858)) |
There was a problem hiding this comment.
URL should point to a commit in the main trunk. Please fix.
|
@Alexisfine please fix conflicts. |
|
@Alexisfine you have not provided a valid link. See: castorini/anserini#2428 Please fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System: Apple M2 Macbook Air
OS: MacOS Sequoia 15.1.1
Python: 3.10.16
Maven: 3.9.9
Java: openjdk 21.0.5
Everything went well.