♻️ Card を border, shadow, border-radius に分解 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ras0q
reviewed
May 24, 2024
|
|
||
| <Meta title="theme/Box" /> | ||
|
|
||
| # Box |
There was a problem hiding this comment.
前は shadow とかがついてたから card 感あったけど、ボタンとかの一般のボックスにも使うし box か になったから
Deploying nascalay-v2-storybook with
|
| Latest commit: |
c0791e2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d1f7a735.nascalay-v2-storybook.pages.dev |
| Branch Preview URL: | https://sslime-decomposition-card.nascalay-v2-storybook.pages.dev |
Deploying nascalay-v2-preview with
|
| Latest commit: |
c0791e2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7edd711e.nascalay-v2-preview.pages.dev |
| Branch Preview URL: | https://sslime-decomposition-card.nascalay-v2-preview.pages.dev |
ras0q
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
一瞬系
表現力が実態とあってなかった
Boxみたいなコンポーネントを作って Props でshadowとかとるようにしてもいいけどasの実装とかめんどいしこのくらいでいいかなって気持ち