Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RTSP return code parsing #1171

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Improve RTSP return code parsing #1171

merged 2 commits into from
Aug 13, 2024

Conversation

Jalle19
Copy link
Collaborator

@Jalle19 Jalle19 commented Aug 12, 2024

@retrofan1979 can you try this branch?

@retrofan1979
Copy link

retrofan1979 commented Aug 12, 2024

Hi, thanks, it looks very good! Maybe check for some errors in the logfile? I stressed the tuners during an extensive test, so maybe the continuity errors are my fault :-)

Channelscan does work now with TransEdit, DVBViewer and Tvheadend. Bravo!

However, I noticed --satip-xml http://192.168.178.1:49000/satipdesc.xml gives 0 devices back instead of 4. Maybe a bug?
I now manually set the tuners with -s dvbc:192.168.178.1 -s dvbc:192.168.178.1 -s dvbc:192.168.178.1 -s dvbc:192.168.178.1
And rarely the stream is interrupted, but the server always does continue the stream.

I also saw a quirck for Aurora client, but this one is very old and not working anymore and I don't know if it still needs to be in the minisatip source code (missing mtype fix).
The same goes for the Geniatech EyeTV Netstream 4C? (fe fix, but maybe useable for other situations)

Overall, I'm very happy with this fix! I think it's ready for release :-)

minisatip.zip

@Jalle19
Copy link
Collaborator Author

Jalle19 commented Aug 13, 2024

However, I noticed --satip-xml http://192.168.178.1:49000/satipdesc.xml gives 0 devices back instead of 4. Maybe a bug? I now manually set the tuners with -s dvbc:192.168.178.1 -s dvbc:192.168.178.1 -s dvbc:192.168.178.1 -s dvbc:192.168.178.1
I think this is a known quirk needed for Fritzbox.

The log looks fine to me in general

@Jalle19 Jalle19 merged commit cdf1749 into catalinii:master Aug 13, 2024
10 checks passed
@Jalle19 Jalle19 deleted the rc branch August 13, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants