Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix satipc module when TEARDOWN is not correctly handled #1187

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

lars18th
Copy link
Contributor

This fixes the edge case when a new tuning call is received in the tuner when the TEARDOWN message is sended to the remote SAT>IP server but the confirmation (OK 200) is not already received. Futhermore improves a bit the logging.

This fixes the edge case when a new tuning call is received in the tuner when the TEARDOWN message is sended to the remote SAT>IP server but the confirmation (OK 200) is not already received. Futhermore improves a bit the logging.
@lars18th
Copy link
Contributor Author

lars18th commented Sep 10, 2024

Hi @catalinii ,

After a lot of time, I've fixed the satipc module. The problem occurs most often when the clients are HTTP with fast channel changes and you're using the RTSP-over-TCP for the SAT>IP protocol. In this case the close of the adpater and the reopening of it occurs while the TEARDOWN is sended and waiting to receive the response. This finally fixes the problem.

As a note, the three //LOGM->LOG comments are not an error. I prefer to leave them to quickly edit the source code and then enable printing of full client and satipc messages without enabling verbose debug (more difficult to read).

Please test it and merge.
Regards.

@catalinii catalinii merged commit 3906d95 into catalinii:master Sep 11, 2024
9 checks passed
@lars18th lars18th deleted the fix2-satipc branch September 11, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants