Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth_saml2 Ignore invalid idp request parameters #869

Open
wants to merge 1 commit into
base: MOODLE_405_STABLE
Choose a base branch
from

Conversation

aneno-m-e
Copy link
Contributor

If the client sends us an idp request parameter that doesn't exist, we simply ignore it, instead of setting it in the session.

This can happen if user's store an old link, becuase saml2 sends you to default idp if it doesn't match, but the session variable still gets set to the invalid nonexisting idp

If the client sends us an idp request parameter that doesn't exist, we
simply ignore it, instead of setting it in the session.

This can happen if user's store an old link, becuase saml2 sends you to
default idp if it doesn't match, but the session variable still gets set
to the invalid nonexisting idp
@danmarsden
Copy link
Member

the use of $_GET makes me sad... it would be nice to clean that up and use optional_param at the same time here.

also - use of the double == looks weird to me and can we be even more clever and use something like array_key_exists() instead of needing the php loop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants