Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#22] Improve 4.x support #23

Closed
wants to merge 1 commit into from

Conversation

matthewhilton
Copy link
Contributor

@matthewhilton matthewhilton commented Jan 30, 2024

Related to #22

Note in 4.4+ Whoops will capture exceptions when using this plugin - its been logged here https://tracker.moodle.org/browse/MDL-80759

To do:

@p8nut
Copy link

p8nut commented Mar 31, 2024

i was able to make the plugin works with the 4.3 by following your changes and commenting the line $event->set_legacy_logdata(array(SITEID, 'webservice', $this->functionname, '' , getremoteaddr() , 0, $this->userid));
(line 316)

@golenkovm
Copy link
Contributor

Thanks @matthewhilton I've cherry picked your commit along with some additional changes. As this turned out to be only 4.2+ compatible I cut a new stable branch https://github.com/catalyst/moodle-webservice_restful/tree/MOODLE_402_STABLE . Closing this PR.

Cheers,
Misha

@golenkovm golenkovm closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants