Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some metadata #20

Merged
merged 10 commits into from
Dec 19, 2024
Merged

Add some metadata #20

merged 10 commits into from
Dec 19, 2024

Conversation

pauladkisson
Copy link
Member

@pauladkisson pauladkisson commented Dec 10, 2024

This PR adds some useful metadata like session_descriptions, genotypes, etc.

Fixes #16

@pauladkisson pauladkisson marked this pull request as ready for review December 10, 2024 23:29
@pauladkisson pauladkisson marked this pull request as draft December 10, 2024 23:29
@pauladkisson pauladkisson marked this pull request as ready for review December 18, 2024 17:16
Copy link

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -25,6 +25,62 @@ BrainRegion:
electrode_group_location: Secondary Motor Cortex (M2)
optogenetic_stimulus_site_location: Secondary Motor Cortex (1.0-1.5 AP, 0.5-0.7 ML)

SubjectMaps:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you lad this as editable metadata? I am surprised this does not throw a validation error.

I have a slight feeling that this would be better in a separate file but your mileage might vary.

Rest looks good to me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised this does not throw a validation error.

Maybe this is a bug, but the validator doesn't check any entries that aren't in the schema at the top level. I could put anything I want in SubjectMaps and it would pass bc it's defined at the top level of the metadata.

I have a slight feeling that this would be better in a separate file but your mileage might vary.

I just like to keep all of the metadata in one place (if it's not already pre-defined elsewhere) to make it easier to edit by the lab.

@pauladkisson pauladkisson merged commit ffc9a60 into main Dec 19, 2024
@pauladkisson pauladkisson deleted the metadata branch December 19, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Metadata
2 participants