Add support for modifying the identifier delimiter

[orware]

You can test the changes made in this PR directly, but the actual test suite may be expecting the SQL-92 specific syntax so it may not be able to directly run the tests when the identifier delimiter has been changed since the generated queries likely won't match anymore.

But by default, the changes proposed here should allow the existing test suite to continue to pass without any changes, since it should still be using the double quote identifier delimiter.

Taking input from Medoo#1044, this adds support for users to modify the quote identifier used for their quotes with databases that might not support the assumed SQL-92 standard double quote delimiter for identifiers.

While I think switching databases into the SQL-92 mode is a good approach generally for making maintenance on the Medoo side simpler, so that the code can be generalized more easily, it's not a workable approach in all situations as described in the issue above by the two PlanetScale users that have run into difficulties.

Similarly though, I could see a Microsoft SQL Server user possibly not wanting to do the same and it causing an issue somehow, although this particular situation does appear to be a bit more PlanetScale specific since the ability for the ANSI_QUOTES option is not supported at this time, nor does it seem to be something that will readily become available in the near future. We've documented this limitation on our MySQL Compatibility page.

Many libraries do allow for the customization of this identifier for their database-specific drivers, but I do understand the Medoo project's desire to keep things as simple and self-contained as possible and I hope the code suggested in this Pull Request is simple enough that it may be considered for users.

// Require Composer's autoloader.
require 'vendor/autoload.php';

// Using Medoo namespace.
use Medoo\Medoo;

// Connect the database.
$database = new Medoo([
    'type' => 'mysql',
    'host' => 'localhost',
    'database' => 'name',
    'username' => 'your_username',
    'password' => 'your_password'
]);

// Usage example of new setIdentifierDelimiter() method:

// For PlanetScale:
$database ->setIdentifierDelimiter('`');

// For something like SQL Server:
$database ->setIdentifierDelimiter('[]');

// You can also use it in a chained manner if you really wanted to (the delimiter would continue to use the new setting afterward):
$database ->setIdentifierDelimiter('`')->select("my_table", '*');

// The changes also correctly adjust the quotes when using the table.column notation in your column list:
$database ->setIdentifierDelimiter('`')->select("my_table", 'my_table.id');

[orware]

Added a small correction in columnQuote() just now.

Didn't realize it until I was eating lunch a few moments ago that the logic was wrong for the potential SQL Server scenario:

// Example:
$data = $db->setIdentifierDelimiter('[]')->select("my_table", 'my_table.id');

// With debugging before the fix:
SELECT [my_table[.]id] FROM [my_table]

// After:
SELECT [my_table].[id] FROM [my_table]

[chriscct7]

This works great! @catfan can this be put into a release?

[catfan]

@orware Thanks for this PR.
@chriscct7

However, it's no need to use a method to set the quotation identifier, because it will only call once in most cases. It can be better to set it from the connection option.

I will design a better way to achieve this, and test more other databases for this feature.

Of course, @chriscct7 can use this PR just now for your migration work.

[chriscct7]

@catfan is there a chance we can get this or something compatible with this like the approach you mentioned merged?

[catfan]

@chriscct7 You can switch to @orware branch https://github.com/orware/Medoo.git and use it directly.

[chriscct7]

Hi there,
I've been using the orware branch for a while, but because it doesn't track in the other changes to the Medoo library, I'd like to circle back on seeing if this could be merged in or if the alternative method per connection you had mentioned has been implemented

[ivanbishop]

Hi, I'm using PHP 8.2 on Ubuntu with MariaDB 10.6.18

I'm using the orware Medoo.PHP file from https://github.com/orware/Medoo.git and just getting 400 errors from my JS call to PHP driven Medoo DB to insert as the inserts are failing due to badly delimited table/column names.

Does this Medoo branch support MariaDB (Mysql derivative)???

Thanks

Ivan

The JSON xHDR data looks like

{
  "session": "e35c3b734d3ad6671c563e3000329a204fa12669d719b886377.42508696",
  "id_prefix": "fca4b",
  "question_i": "Find the cloud.",
  "question_a": "What is the 2nd digit in 3658990?",
  "answers": [
    "dcd857526f2c79f6b00d",
    "1ac0e4d251fe4ec59ffc",
    "9a85bcbdf368abc576b6",
    "adb5c8daba2c9deb7a59",
    "8b9aee9d34448134c473"
  ]
}

**the INSERT looks like** 
Medoo\Medoo Object
(
    [pdo] => PDO Object
        (
        )

    [type] => mysql
    [prefix:protected] =>
    [identifierDelimiter:protected] => ``
    [statement:protected] => PDOStatement Object
        (
            [queryString] => INSERT INTO `sessions` (`skey`, `aid`, `acqid`, `expired`, `timestamp`, `ipaddr`) VALUES (:MeD3_mK, :MeD4_mK, :MeD5_mK, :MeD6_mK, NOW(), :MeD7_mK)
        )

    [dsn:protected] => mysql:dbname=captcheck;host=localhost
    [logs:protected] => Array
        (
            [0] => Array
                (
                    [0] => INSERT INTO `sessions` (`skey`, `aid`, `acqid`, `expired`, `timestamp`, `ipaddr`) VALUES (:MeD3_mK, :MeD4_mK, :MeD5_mK, :MeD6_mK, NOW(), :MeD7_mK)
                    [1] => Array
                        (
                            [:MeD3_mK] => Array
                                (
                                    [0] => 620ceb734d3ad6671c563e3000329a204fa12669d727f4ba1b8.26822944
                                    [1] => 2
                                )

                            [:MeD4_mK] => Array
                                (
                                    [0] => 23
                                    [1] => 1
                                )

                            [:MeD5_mK] => Array
                                (
                                    [0] => 38
                                    [1] => 1
                                )

                            [:MeD6_mK] => Array
                                (
                                    [0] => 0
                                    [1] => 1
                                )

                            [:MeD7_mK] => Array
                                (
                                    [0] => 50.211.205.49
                                    [1] => 2
                                )

                        )

                )

        )

My Medoo PHP includes mysql as the server type

The PHP code doing the insert contains
$database ->setIdentifierDelimiter('');
`