Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

Commit

Permalink
Merge pull request #303 from saneyuki/rule
Browse files Browse the repository at this point in the history
[typescript-eslint] Enable explicit-module-boundary-types
  • Loading branch information
tetsuharuohzeki authored Jan 21, 2020
2 parents a60dada + 7009704 commit b3a9f57
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions config/eslintrc_typescript.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,13 @@ module.exports = {
},
}],

// TODO: #301
'@typescript-eslint/explicit-module-boundary-types': 'off',
// Function's in/out are one of the important place to ensure type safety.
'@typescript-eslint/explicit-module-boundary-types': ['warn', {
'allowTypedFunctionExpressions': true,
'allowHigherOrderFunctions': false,
'allowDirectConstAssertionInArrowFunctions': false,
'allowedNames': [],
}],

// * We accept the style for T , TA , TAbc , TA1Bca , T1 , T2.
// * You seem this style is similar to C# or typescript compiler.
Expand Down Expand Up @@ -283,11 +288,6 @@ module.exports = {
// We allow this this kind of redundant code because it sometimes prevents a mistake.
'@typescript-eslint/no-unnecessary-type-assertion': 'off',

// I think this rule is useful.
// But I'm not sure about that the relation with `noImplicitAny` compiler option.
// FIXME(#257)
'@typescript-eslint/no-untyped-public-signature': 'off',

// This should be sorted with ESLint builtin rule.
'no-unused-expressions': 'off',
'@typescript-eslint/no-unused-expressions': 'error',
Expand Down

0 comments on commit b3a9f57

Please sign in to comment.