Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flake8 error "E741 ambiguous variable name 'O" #73

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Mar 23, 2023

No description provided.

@cool-RR cool-RR marked this pull request as ready for review March 23, 2023 09:53
@cool-RR
Copy link
Contributor Author

cool-RR commented Mar 23, 2023

@Jamesfox1 This might fix the Flake8 problem. It says "1 workflow awaiting approval". Can you approve running the workflow to see whether it passes?

@Jamesfox1
Copy link
Collaborator

@Jamesfox1 This might fix the Flake8 problem. It says "1 workflow awaiting approval". Can you approve running the workflow to see whether it passes?

Does it pass the flake8 test locally? i.e., when you run [tests/check-code.sh](https://github.com/causalincentives/pycid/blob/master/tests/check-code.sh)?

@cool-RR
Copy link
Contributor Author

cool-RR commented Mar 23, 2023

Yes, flake8 passes locally. Lots of MyPy errors but I won't dive into those.

@Jamesfox1
Copy link
Collaborator

Jamesfox1 commented Mar 23, 2023

Yes, flake8 passes locally. Lots of MyPy errors but I won't dive into those.

Okay, thanks! As said above, I'll need to wait until the weekend to look into this!

@cool-RR
Copy link
Contributor Author

cool-RR commented Apr 2, 2023

🦗

@Jamesfox1 Jamesfox1 merged commit e3adf67 into causalincentives:master Sep 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants