feat: add instructions for token and system program #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find a work here: https://github.com/Aursen/nostdinfo-programs |
Aursen
reviewed
Nov 23, 2024
|
|
||
| use crate::ProgramResult; | ||
|
|
||
| pub fn invoke_signed( |
There was a problem hiding this comment.
Calling this method invoke signed is a bit misleading
There was a problem hiding this comment.
how so? can you elaborate more ser
There was a problem hiding this comment.
For example, in the verified call, we check whether the metas accounts agree with the accounts in the instruction. Since .to_metas-C is account-based, I don't know if it's accurate in this context @cavemanloverboy any ideas?
|
It may be a good idea to optimize the array assignment like pinocchio |
Aursen
reviewed
Nov 26, 2024
| @@ -1,5 +1,5 @@ | |||
| [workspace] | |||
| members = ["solana-nostd-entrypoint", "example-program"] | |||
| members = ["solana-nostd-entrypoint", "example-program", "system", "token"] | |||
There was a problem hiding this comment.
Maybe here organize to use the crates folder and the examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this internally and thought it might be helpful for anyone using nostd-entrypoint, I've yet to finish the other instructions - wanted to check If it might be worth supporting.
Most of it is from @febo 's Pinocchio token and system program so thank you for that, was really helpful :D