Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Solver] Two-Phase One-Point Explicit #680
base: develop
Are you sure you want to change the base?
[Solver] Two-Phase One-Point Explicit #680
Changes from 196 commits
bbf7c51
f3f6fb2
ad09dfa
ac84455
26e5ed9
e68ab89
d40b6b0
67303d8
0a6ac16
adfd93f
2b92b3f
336cfe6
91d5c97
8ed2eb8
02911bf
0feaf6d
bcfb878
99b9eea
315cfae
2f54b90
0facda0
4136654
9da224f
cb71c90
52eb2b3
a20a2ab
0a0cf7b
fe0f9bf
b693709
5fc100e
bfee43a
2727d34
f9602fd
a3ee684
45aa3ba
212505e
1251bd7
27ea5d6
b888b07
ae339f1
7491c34
3e1aae3
f34b64c
164491f
3d35f45
deb54a7
fcfcf87
385fcca
86341a6
c8b65cd
5421984
23be100
83a1257
fc8a8a2
222ca55
da461c3
532aca8
b017a99
6de587f
9f42d94
da1682e
3e1f9ff
a687fa8
47c5f48
6e2913b
4899191
b8a3932
f2a982c
68506c1
0666b0a
2858001
a893ffe
fc1e539
16b1ed8
416b314
b32693e
46e0b67
32989ad
99882d2
6c066c3
aa7ddfe
85e76db
3e29ecf
974a86d
5400fd2
178eff0
3da5b25
c69843f
6b1a3ce
a015f4f
9fe7d02
966d51a
56bc776
bff49ec
feaa3d1
a118f4d
dc7eeab
284a0dd
cbd3ef9
82d8ab0
ed844c9
3cad6b3
1961366
cae6cfe
095fe39
4919e84
d6681a8
b70e28d
a853aac
afc5b15
c6f4d7b
52f5e0d
8b09a3c
48298d7
a281034
cde881d
bb2fcc0
493ddb4
7cb30f9
01c999c
becdfaa
eff342f
7f2f40d
55a5eed
be2bbb9
304f54a
98b7763
311be05
708c6d0
ae45f5d
656f384
7239a63
c68fbd5
8bb993b
783c17e
b208bf4
29aeb9c
82bef32
af1abe1
6ac4a1b
64c8bab
617efba
288b8aa
ec91bc0
5af4700
dc2ec42
4806e09
65d579e
859e174
174c5d0
0b3fd01
1571da3
594aa68
2b6cf4b
c602ced
4dedd01
7081c0e
a4dfb76
6992ada
8b7f384
7f42f58
78a0e5a
c919841
2a2a1a8
80b2817
f7c0af9
5eebcf3
bf1fb24
0ace406
2005506
c0ffa57
5366faf
5e04ad3
37428ed
0df173e
902e10b
b69d846
d05373f
2149eaf
e24d2f1
2a741de
7f96225
974764a
33f5e97
f272ee7
0738ab2
79820f2
5abd743
e3127d1
6e40958
b79e05a
5763fd0
c2b48f2
9f3cc4a
f6022df
1b34a27
ad851bf
ae2b6fe
b8a7d89
ae92ec0
62e065c
32f1c5a
2b195ee
689d9fb
c24b27e
4f550b1
2ddbf23
fe725f6
eae0fbf
72dbc24
2ad9bc2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this affect GIMP and other non-local algorithms?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... That's a good point, but I don't think the free-surface detection can be used for non-local MPM yet in general, so I am expecting this function won't work well too for non-local MPM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we doing this only for cells with particles? The function looks generic so adding this for only cells with particles looks strange. Could we instead pass it as a function argument?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only do this for cells with particles as otherwise, the
nodes_->update_volume()
will be called as many numbers as the MPI thread. Therefore, without checking thestatus()
, we won't have the free_surface detection working in parallel.