Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Physical Time to VTK Outputs for #727 #729

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

mfontaine218
Copy link

Describe the PR
Added physical time to MPI-parallel VTK outputs so that physical simulation time can be seen in ParaView visualization, .pvd files are created for each attribute with time step included.

Related Issues/PRs
Related to issue #727

image

Adding physical time to vtk output
Adding physical time to vtk output
Adding physical time to vtk output
Adding physical time to vtk output
@jgiven100
Copy link
Collaborator

@mfontaine218 Looks like you'll need to run clang-format to get the circleci checks to pass

@jgiven100 jgiven100 requested a review from kks32 April 16, 2022 01:35
@jgiven100 jgiven100 self-requested a review April 16, 2022 01:36
@jgiven100 jgiven100 removed their request for review April 16, 2022 01:37
@kks32 kks32 self-assigned this Apr 18, 2022
@shellshocked2003
Copy link

@mfontaine218, as @jgiven100 pointed out, the build is failing due to file formatting not meeting the repository standard. Running clang-format will automatically adjust the files to the specified formatting, so shouldn't be a hard fix. Please let me know if you have any issues/questions about that.

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #729 (bd3284d) into develop (adfe6f1) will decrease coverage by 0.02%.
The diff coverage is 75.86%.

@@             Coverage Diff             @@
##           develop     #729      +/-   ##
===========================================
- Coverage    96.75%   96.73%   -0.02%     
===========================================
  Files          130      130              
  Lines        25932    25961      +29     
===========================================
+ Hits         25090    25112      +22     
- Misses         842      849       +7     
Impacted Files Coverage Δ
include/solvers/mpm_base.tcc 77.04% <ø> (ø)
src/io/vtk_writer.cc 92.90% <74.07%> (-3.97%) ⬇️
tests/io/vtk_writer_test.cc 97.18% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adfe6f1...bd3284d. Read the comment docs.

Copy link
Contributor

@kks32 kks32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.


// Write parallel grouping VTK file

std::string output_path = filename.substr(0, filename.find_last_of("\\/"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens on a Windows system?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants