-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Physical Time to VTK Outputs for #727 #729
base: develop
Are you sure you want to change the base?
Conversation
Adding physical time to vtk output
Adding physical time to vtk output
Adding physical time to vtk output
Adding physical time to vtk output
@mfontaine218 Looks like you'll need to run |
@mfontaine218, as @jgiven100 pointed out, the build is failing due to file formatting not meeting the repository standard. Running |
Codecov Report
@@ Coverage Diff @@
## develop #729 +/- ##
===========================================
- Coverage 96.75% 96.73% -0.02%
===========================================
Files 130 130
Lines 25932 25961 +29
===========================================
+ Hits 25090 25112 +22
- Misses 842 849 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
||
// Write parallel grouping VTK file | ||
|
||
std::string output_path = filename.substr(0, filename.find_last_of("\\/")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens on a Windows system?
Describe the PR
Added physical time to MPI-parallel VTK outputs so that physical simulation time can be seen in ParaView visualization, .pvd files are created for each attribute with time step included.
Related Issues/PRs
Related to issue #727