Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exif data support #30

Open
ryhorne opened this issue Sep 15, 2020 · 4 comments
Open

exif data support #30

ryhorne opened this issue Sep 15, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@ryhorne
Copy link

ryhorne commented Sep 15, 2020

Hiya, I've tried out this project and it's the best fit so far for a simple photo gallery. I was just wondering if there's any plans for displaying EXIF data? I'm terrible at JS, else I'd offer assistance personally
Cheers

@cbenning
Copy link
Owner

Cool, I had done some preliminary work on (not exif) but displaying things in overlays on top of images and on the side (like face tags). I stopped because there was a bug in the underlying library that fussel uses for the image gallery and was waiting for them to fix it. However, this is definitely something I think that would be a great addition so once I sort out that blocking issue I will look at adding exif data for sure.

Just to get the ball rolling, how do you see it working? A toggle in the cofig for whether it should be shown? or a context "show exif", or a side bar or something? Any suggestions for how that might be used would be great.

PS most of the "work" is done in python, then just displayed in JS.

Cheers

@cbenning
Copy link
Owner

Here is the ticket for reference, that has stopped me from doing much work in the area of context data overlays: #3

@ryhorne
Copy link
Author

ryhorne commented Sep 16, 2020

Oh, in the case that most of it is done in Python, I'll take a look this weekend at your project to see if I can dissect how it works.

In my opinion, the more config options (with reasonable defaults), the better. I know that I'd always display the EXIF data on my site, but maybe someone wouldn't want to.

As for ideas of how to display it, I'm not sure, but here's some ideas from other projects that I attempted to use before I stumbled upon yours. Again, I'm not too familiar with HTML/JS in general, so I'm unsure of what limitations your project may be under. Apologies for the MS Paint!




Sigal (another static site generator) appears to use some semi-transparent overlay box. This appears to have some data formatting issues, but it's an idea. I'd imagine that we would prefer a fraction for shutter speed and having nice spacing around the stats

exif_sigal




pigallery2 uses a side-bar. I wouldn't expect functionality like maps and such at the beginning, but perhaps with a route like this, we could add more data to this area as the functionality is expanded.

exif_pigallery2_

@cbenning
Copy link
Owner

Very cool. Deinitely achievable. We could do it in one of two ways:

  • Have the JS pull the data out of the image. I'm not sure if there are performance implications
  • Have the python extract this information, and store it in json so the JS can just display it.

We could pick one, or have either/or working in the config.

Right now the problem blocking me was less the exif part, and more that the drawing on the canvas was not working. I'm considering looking at a new JS gallery component to help with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants