Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation of EXIF data popup and sorting in album level #140

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Nambers
Copy link

@Nambers Nambers commented Feb 12, 2025

#30
I use PIL lib to extract EXIF data from img. I'm not very good at design page so it's a simple implementation and I believe there are plenty of room to improve.
It will be like
image

@cbenning
Copy link
Owner

This looks really great! I'm no expert on UI/UX, im open to ideas on how we show this in a clean way.

@Nambers
Copy link
Author

Nambers commented Feb 14, 2025

@cbenning I ended up by making an additional info page for that
e.g.
image
(under 67% scale)

but it is not compatible with mobile view rn. It may be better with some React component.
How do u feel about it?

@Nambers Nambers requested a review from cbenning February 14, 2025 04:17
@cbenning
Copy link
Owner

@cbenning I ended up by making an additional info page for that e.g. image (under 67% scale)

but it is not compatible with mobile view rn. It may be better with some React component. How do u feel about it?

Ah so not in the modal anymore?

@Nambers
Copy link
Author

Nambers commented Feb 14, 2025

@cbenning I ended up by making an additional info page for that e.g. image (under 67% scale)
but it is not compatible with mobile view rn. It may be better with some React component. How do u feel about it?

Ah so not in the modal anymore?

Yes, it is on different page, bc showing these bunch of information above the image is not clear enough to read? You can try to generate on my fork to see the result.

@Nambers
Copy link
Author

Nambers commented Feb 15, 2025

I also implemented sorting of albums (by date or name).
Sorry to mix those codes in this PR, but I need EXIF data to achieve that.

@Nambers
Copy link
Author

Nambers commented Feb 15, 2025

I deployed it in my environment. Feel free to check it https://photos.ikuyo.dev/!

@Nambers Nambers changed the title implementation of EXIF data popup implementation of EXIF data popup and sorting in album level Feb 16, 2025
@Nambers
Copy link
Author

Nambers commented Feb 23, 2025

btw FYI, I re-implemented your design in Gatsby published here https://github.com/Nambers/AnotherFussel
so feel free to close PR if you think it is a bit off your design concept!

@cbenning
Copy link
Owner

I really like what you're doing here. I sent you an email to discuss future stuff, but for now my feedback is:

I love this progress. My initial impression is that clicking on a button in a modal takes you out of a modal is a bit jarring but I don't know how better to do it, unless we bring another layer up on top of the modal. I'm also open to discussing a totally different modal-design or implementation as well.

My usage is simplistic, and I think Fussel should remain simple-by-default visually with a LOT of cool features that can be enabled such as this EXIF info.

@Nambers
Copy link
Author

Nambers commented Feb 23, 2025

I really like what you're doing here. I sent you an email to discuss future stuff, but for now my feedback is:

I love this progress. My initial impression is that clicking on a button in a modal takes you out of a modal is a bit jarring but I don't know how better to do it, unless we bring another layer up on top of the modal. I'm also open to discussing a totally different modal-design or implementation as well.

My usage is simplistic, and I think Fussel should remain simple-by-default visually with a LOT of cool features that can be enabled such as this EXIF info.

Ty for the feedback!
For the enable part, it's easy to support: my config part is written in typescript and engaged in building process. I'll support that. rn I'm working on the map page: re-group photos under geography etc.
ig maybe we can just pop new tab for the info page. But idk, this may a bit off the Single-Page-Application design concept of Gatsby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants