Refactor Parameterized and ParameterDescription class to improve separation of concern #586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
ParameterDescription.java
This PR refactors the addValue method by extracting the logic for handling collection type parameters into a separate method.
Changes:
handleCollectionTypeParameter
in the classRationale:
Parameterized.java
This PR refactors the
parseArg
method by extracting the field analysis logic into a separate method.Changes:
analyzeFields
that encapsulates the field analysis logicparseArg
to call the new analyzeFields method where appropriateAdditionally, it refactors the
parseArg
method by extracting the method analysis logic into a separate method.Changes:
analyzeMethods
that encapsulates the method analysis logicparseArg
to call the newanalyzeMethods
method where appropriateRationale:
parseArg
method now focuses on high-level argument parsing, while field and method analysis are handled separately.parseArg
method becomes more concise and easier to understand.parseArg
logic.Note: