RPi 4 multiple display support #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw you had some comments about supporting this eventually... Seems to work from basic testing, still need to integrate it with my own project for some more thorough exercise.
PS: I haven't been able to find the email you sent... You can also try my backup email zacajhosting at gmail.com, or I'm zacaj#5386 on discord. Or if you feel comfortable posting your email publicly I can email you? Idk, would like to chat and discuss a few things in more detail.
On that subject, I discovered an intermittent+hard to reproduce bug involving deleting and modifying a bunch of AminoText objects on the fly, eventually tracked it down to enqueued property updates running after their object was deleted. I made a quick fix on my fork (zacaj@6f2e44a) that seems to have resolved it, but not sure if there's a cleaner way to do it since I'm not too familiar with the overall architecture