-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.13 roadmap #235
Comments
Still pinned to Also would be good to tackle this at the same time as #230. I can open a WIP PR to switch to |
WFDB still has that NumPy pin, but I'm not really sure that we need to have it (maybe it was never necessary in the first place, I can't remember why I introduced it). So yes, I'm happy to remove it (do you want to make a PR?)! Regarding abi3 wheels, it would be great if you could do it! Are there any drawbacks compared to non-abi3 wheels? Why is not everyone using abi3 wheels by default? |
If you write code that uses C Python calls, sometimes you have to use less efficient ones. So you have to make sure all API calls are in here https://docs.python.org/3/c-api/stable.html So far in other repos I've only needed to change a few small list or tuple access/query function calls with minimal impact on performance. We'll see here pretty quickly (hopefully) if we hit something that would be too hard or too slow to change over.
I don't think that many people know about them, and not super well supported by Cython, and not particularly well documented most places. SWIG just added support in the last year. NumPy just added docs saying you can build wheels with a dependency on their API and it is abi3 compatible, etc. |
Looks like the real limiting factor now is MIT-LCP/wfdb-python#511. @cbrnr so that sleepecg doesn't get caught up in their (slow) timeline WDYT I'll try making it a more clearly optional dep in my PR |
Let's leave this open until all packages support 3.13. |
@cbrnr time for a release? Would be good for 3.13 and NumPy 2 support! |
Yes, will do! |
@larsoner publishing fails because the Linux aarch64 runner cannot run the tests (numba does not exist for that architecture). What do we do? https://github.com/cbrnr/sleepecg/actions/runs/13071700291 |
Numba is an optional requirement right? I would make those tests optional and mark them with |
We cannot enable Python 3.13 currently, because
The text was updated successfully, but these errors were encountered: