-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: abi3 #251
ENH: abi3 #251
Conversation
At least locally:
|
* upstream/main: MAINT: Trivial CI bump (cbrnr#252)
Okay I think this one is good to go @cbrnr |
This is great 🚀, thank you so much @larsoner! I only have a couple of questions just so I understand everything you did here:
|
I just changed openmeeg and it has: A bit odd actually that it doesn't say
Yes all related, you might need to configure something on https://app.codecov.io/gh/cbrnr/sleepecg but I'd wait until something landed in main. And you'll want to take the token from there and add it as a GitHub secret as CODECOV_TOKEN.
Yeah I think you should be able to install all dependencies in all runs rather than triaging based on NumPy/Python version.
Maybe not, but given the issues with NumPy 2.0 rollout it seems safest. I thought they recommended it at one point but I can't find a record of it, so it could be removed.
No idea, I've actually never used uv. But @mscheltienne has and I think liked it
Okay, not totally necessary. There were some additions to the stable API for 3.10 that I thought you might need as well but it doesn't look like it! |
I use |
I'm already using the build and publish parts of uv (together with all the rest), it works perfectly! I'll make a follow up PR to switch to uv, this should simplify some things. |
Thanks @larsoner! I just realized that you did not add a changelog entry. Do you want to add something? I think this is a pretty important change, since Python 3.13 is now supported. |
Sure, do you want to just add it to #253 ? If not I can make a quick PR |
Please make a quick PR, otherwise I might forget again! |
Closes #230
Closes #235
aarch64
builds (hopefully fast enough?)abi3audit
to check the wheelsWorth bumping to 3.10+ at the same time?