Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump JsonPath.Net to v1.0.0 #144

Closed
wants to merge 2 commits into from
Closed

Bump JsonPath.Net to v1.0.0 #144

wants to merge 2 commits into from

Conversation

glyn
Copy link
Collaborator

@glyn glyn commented Feb 23, 2024

See #143

@glyn glyn requested a review from gregsdennis February 23, 2024 12:39
@glyn glyn self-assigned this Feb 23, 2024
@glyn
Copy link
Collaborator Author

glyn commented Feb 23, 2024

@gregsdennis Do you think there is more to bumping the version than just this?

@gregsdennis
Copy link
Collaborator

No. Just bumping should be fine. It's not doing anything custom (like defining functions), so the breaks introduced in 0.8 shouldn't be a problem.

gregsdennis
gregsdennis requested changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@gregsdennis gregsdennis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change target framework to net6.0. Sorry, missed that initially.

@glyn
Copy link
Collaborator Author

glyn commented Feb 24, 2024

Change target framework to net6.0. Sorry, missed that initially.

Fixed.

@glyn glyn requested a review from gregsdennis February 24, 2024 15:37
gregsdennis
gregsdennis approved these changes Feb 24, 2024
View reviewed changes
Copy link
Collaborator

@gregsdennis gregsdennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that should be it. I don't see a docker file or anything.

@cburgmer
Copy link
Owner

Merged in 3a12233

@cburgmer cburgmer closed this Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregsdennis gregsdennis gregsdennis approved these changes

Assignees

@glyn glyn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glyn @gregsdennis @cburgmer