Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment: remove root privilege and add configfs permission for ccnp #62

Merged
merged 1 commit into from
May 7, 2024

Conversation

dongx1x
Copy link
Member

@dongx1x dongx1x commented May 6, 2024

No description provided.

@dongx1x dongx1x requested review from Ruoyu-y and ruomengh May 6, 2024 06:44
Copy link
Member

@Ruoyu-y Ruoyu-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruomengh
Copy link
Contributor

ruomengh commented May 6, 2024

CVM image rewriter needs update to set the file permission

Copy link
Contributor

@ruomengh ruomengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +5 to +6
D /sys/kernel/config/tsm/report/ccnp 0757 - - -
f /sys/kernel/config/tsm/report/ccnp/inblob 0666 - - - -
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruomengh I have added permission here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@dongx1x dongx1x merged commit 24bccf7 into cc-api:main May 7, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants