Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #147 #151

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Conversation

Giraaffes
Copy link

As mentioned in #147, there's a huge issue in singleplayer on 1.18.2 v1.100.8 where chunks with computers in them won't save, unless the player stays on the menu screen for long enough. I assume there's some good reason that the way it's fixed in c09735c can't or shouldn't be backported, but the issue pretty much makes this version of the mod unplayable.

Checking if the server still exists before broadcasting a computer delete message fixes it (the same way it's done in UpgradeSpeakerPeripheral)

@Merith-TK
Copy link
Collaborator

Make the checks succeed and get atleast another person verify it works and I will merge,

(if it's a bug with the checks let me know and I will look into it as I am at work at time of writing. This)

@Giraaffes
Copy link
Author

I've had my friend verify that this also fixes the issue on their computer. As for the checks I've got no clue. It says that "license violations were found" in a lot of classes during the build, but all I've really done is add 2 lines of code.

@Merith-TK
Copy link
Collaborator

@SquidDev wasnt this build thing supposed to be fixed at one point a while ago?

@Merith-TK Merith-TK merged commit 0e90d5e into cc-tweaked:mc-1.18.x/1.18.2 Sep 15, 2023
1 check passed
@Merith-TK
Copy link
Collaborator

will make "release" later after work, I dont have my 2FA key with me so I cant make sure the Curseforge page will update properly

@Giraaffes
Copy link
Author

Are you going to make a release? Not to rush you or anything, just making sure it hasn't been forgotten.

@Merith-TK
Copy link
Collaborator

Sorry, night-shift at walmart not conducive to memory

@Giraaffes
Copy link
Author

No problem

@wallth144
Copy link

Hi, any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants