Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added and example to Envelopes notebook #55

Merged
merged 7 commits into from
Mar 2, 2024

Conversation

AlexGriffiths526
Copy link
Contributor

Hi Colin, sorry it has taken me so long I have had a few problems with my git authentication. Nevertheless, I have put together an example for CS 454 in the Envelopes notebook.

There area couple of points to note:

  • To simplify the problem I have limited the application of load to either loading a full span or not at all. This may produce action effect slightly less than the maximum. I think a more elegant method may be to use the coordinates from the IL diagram to position the load where it has the most onerous effect. Like a reservoir filling up if you like.
  • The example makes use of the envelope feature but not the load patterning so it might not be exactly what you are after. if it is not what you are after I won't be offended at all if you don't want to include the example.

Thanks again for sharing the library.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.60%. Comparing base (e580334) to head (2cf4a09).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   80.60%   80.60%           
=======================================
  Files          13       13           
  Lines        1356     1356           
=======================================
  Hits         1093     1093           
  Misses        263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ccaprani
Copy link
Owner

ccaprani commented Mar 2, 2024

Thanks @alexandergriffiths526 ! That's great. I made a few tweaks to make it more generic. It was a really good solution to use the LoadPattern object. However, I realised it could be simpler (at least conceptually, the code is similar) to use the Envelopes class. It just needed a factor_LM method. I'll add this and then revise the notebook accordingly shortly.

Sorry it took so long to get to this, but I'm really grateful for the PR and contribution to the package!

@ccaprani ccaprani merged commit 86fbc6f into ccaprani:main Mar 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants