Adding find completed items and find items by image #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--Added find completed items. Was in the eBay API but not in rebay. --Added find items by image. Was in the eBay API but not in rebay. --Added test coverage for find completed items and find items by image. --Added json responses for both find completed items and find items by image for tests.
|
Added two API calls that are not in rebay that are included in the eBay Finding API. Added json responses for the tests and added tests for each API call. |
|
Any word on whether this'll get merged in? This functionality would be a huge add. |
|
@michaeldcruz I am not sure. It has been open for over a year (almost 2). I don't think rebay is in development any more. I'm going to keep this pull request open just in case it should ever get looked at. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--Added find completed items. Was in the eBay API but not in rebay.
--Added find items by image. Was in the eBay API but not in rebay.
--Added test coverage for find completed items and find items by image.
--Added json responses for both find completed items and find items by
image for tests.