Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advent of Code 2024 - Day 5 #25

Merged
merged 2 commits into from
Dec 29, 2024
Merged

Advent of Code 2024 - Day 5 #25

merged 2 commits into from
Dec 29, 2024

Conversation

cdalvaro
Copy link
Owner

  • Solve puzzle 2024-05

@cdalvaro cdalvaro added the puzzle Solve a puzzle label Dec 29, 2024
@cdalvaro cdalvaro requested a review from Copilot December 29, 2024 10:46
@cdalvaro cdalvaro self-assigned this Dec 29, 2024
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 11 changed files in this pull request and generated 1 comment.

Files not reviewed (5)
  • sig/puzzles/2024/day05.rbs: Language not supported
  • sig/test/puzzles/2024/day05_test.rbs: Language not supported
  • test/puzzles/2024/day05/test_data.txt: Language not supported
  • README.md: Evaluated as low risk
  • lib/puzzles/2024/day05/part2.rb: Evaluated as low risk
Comments suppressed due to low confidence (2)

lib/puzzles/2024/day05/update_manager.rb:29

  • [nitpick] The parameter name 'update:' is unconventional. It should be renamed to 'update' without the colon.
def valid?(update:)

lib/puzzles/2024/day05/update_manager.rb:45

  • [nitpick] The parameter name 'update:' is unconventional. It should be renamed to 'update' without the colon.
def fix_ordering(update:)

lib/puzzles/2024/day05/update_manager.rb Show resolved Hide resolved
Remove unused variable
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (182cedd) to head (2f38157).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          60       64    +4     
  Lines        1177     1242   +65     
  Branches      103      105    +2     
=======================================
+ Hits         1176     1241   +65     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdalvaro cdalvaro merged commit 130a560 into main Dec 29, 2024
4 checks passed
@cdalvaro cdalvaro deleted the puzzle/2024/day05 branch December 29, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
puzzle Solve a puzzle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant