Ux enhancements for error classification #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GnsP
force-pushed
the
error-classification-ui
branch
from
426e602 to
9ddbe58
Compare
njbriggs
reviewed
Jan 24, 2025
| RESET: `${ACTION_PREFIX}/RESET`, | ||
| }; | ||
|
|
||
| function errorDetailsBannerUiReducer( |
There was a problem hiding this comment.
Move to a separate file? It's going to be hard to follow the code if some reducers/stores are in their own files, but others are embedded with UI components.
| ); | ||
| } | ||
|
|
||
| export default function PipelineRunErrorDetails() { |
There was a problem hiding this comment.
This file is getting pretty big. Please move each component to its own file.
GnsP
force-pushed
the
error-classification-ui
branch
from
9ddbe58 to
e42c17f
Compare
radhikav1
approved these changes
Jan 27, 2025
itsankit-google
approved these changes
Jan 28, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ux enhancements for error classification
Description
The following updates are included.
PR Type
Links
Jira: CDAP-21100
Test Plan
e2e tests to be added, when support for error classification in hydrator plugins is added.
currently it's infeasible to add e2e tests for this feature that can run in the gh-runner envirinment.
Screenshots