e2e groupby conditional scenarios #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanathi-g
reviewed
Sep 11, 2023
| Then Validate output file generated by file sink plugin "fileSinkTargetBucket" is equal to expected output file "groupByTest5OutputFile" | ||
|
|
||
| @GROUP_BY_TEST @FILE_SINK_TEST | ||
| Scenario: To verify complete flow of data extract and transfer from File source to File sink with GroupBy plugin using set of aggregates |
There was a problem hiding this comment.
nit: update scenario description to mention which aggregates are being tested (count, sum, max)
There was a problem hiding this comment.
Updated scenario description.
itsmekumari
force-pushed
the
e2e_groupby
branch
from
eeb3c8b to
f05cb94
Compare
Added minif and anyif aggregators in first scenario. |
itsmekumari
force-pushed
the
e2e_groupby
branch
5 times, most recently
from
f3e218e to
3502087
Compare
vanathi-g
approved these changes
Sep 13, 2023
itsmekumari
force-pushed
the
e2e_groupby
branch
5 times, most recently
from
8fbb96b to
32db009
Compare
itsmekumari
force-pushed
the
e2e_groupby
branch
from
32db009 to
05afe37
Compare
|
e2e test failure seems to be due to "Verify Distinct plugin validation errors for incorrect data in Fields" (src/e2e-test/features/distinctplugin/DistinctErrorScenarios.feature:5) scenario. Merging since it is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design document available in PR review folder.