[PLUGIN-1742] Fix EmptyInputFormat failure outside of Core Plugins #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psainics
force-pushed
the
patch_AbstractEmptyInputFormat
branch
4 times, most recently
from
d01aa45 to
784b648
Compare
psainics
force-pushed
the
patch_AbstractEmptyInputFormat
branch
from
784b648 to
dbd5473
Compare
fernst
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix EmptyInputFormat failure outside of Core Plugins
Description
Plugins that extend from AbstractFileSource (link) which are outside of the Core Plugins module will not correctly export the EmptyInputFormat that is required when we need to handle the case where the source input is empty.
Patch Description
This PR adds a method
getEmptyInputFormatClassNamethat class can override to provide their own implementation for an emptyInputFormat.Renamed
EmptyInputFormattoAbstractEmptyInputFormatso this can be extended by other classes as their ownEmptyInputFormatto reduce code duplication.