Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🍒][PLUGIN-1771] Add Streaming support for excel source #1853

Merged
merged 1 commit into from
Apr 12, 2024
Merged

[🍒][PLUGIN-1771] Add Streaming support for excel source #1853

merged 1 commit into from
Apr 12, 2024

Conversation

psainics
Copy link
Contributor

@psainics psainics commented Apr 4, 2024

[Cherrypick]
Commit : 0d12023
PR: #1847

Add Streaming support for excel source

Jira : PLUGIN-1771

Description

Excel plugin consumes huge memory when reading large files.
This is due to it loading the complete file in it's memory.

This PR adds streaming support xlxs filetype.

  • As we won't be able to stream old xls binary based format we use magic bytes to detect the filetype.

UI Field

  • No Changes made to widget json.

Docs

  • No Changes made to docs.

Code change

  • Modified ExcelInputFormat.java

Unit Tests

  • No Changes made to unit tests.

@psainics psainics added the build Trigger unit test build label Apr 4, 2024
fernst
fernst approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@fernst fernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psainics psainics merged commit e30e037 into cdapio:release/2.12 Apr 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernst fernst fernst approved these changes

@samdgupi samdgupi Awaiting requested review from samdgupi

Assignees
No one assigned
Labels
build Trigger unit test build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psainics @fernst