e2e groupby additional tests #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmekumari
force-pushed
the
e2e-tests_groupby
branch
2 times, most recently
from
dbadcbf to
a7aa203
Compare
itsmekumari
force-pushed
the
e2e-tests_groupby
branch
from
a7aa203 to
002e0cf
Compare
|
|
||
| @Before(order = 1, value = "@GROUPBY_TEST") | ||
| public static void createBucketWithGroupByTest2File() throws IOException, URISyntaxException { | ||
| gcsSourceBucketName1 = createGCSBucketWithFile(PluginPropertyUtils.pluginProp("groupByGcsCsvTestFile")); |
There was a problem hiding this comment.
Are we using constant names for source files?
There was a problem hiding this comment.
Yes, we are using constant names for source files and providing the path in plugin parameters file.
| @@ -29,3 +29,6 @@ errorLogsMessageDistinctInvalidFields=Spark program 'phase-1' failed with error: | |||
| errorLogsMessageDistinctInvalidNumberOfPartitions=Spark program 'phase-1' failed with error: Unable to create config \ | |||
| for batchaggregator Distinct 'numPartitions' is invalid: Value of field class io.cdap.plugin.\ | |||
| batch.aggregator.AggregatorConfig.numPartitions is expected to be a number.. Please check the system logs for more details. | |||
| errorLogsMessageGroupByInvalidFields=Spark program 'phase-1' failed with error: null. | |||
There was a problem hiding this comment.
This error message signifies nothing and does not help in any kind of validation.
There was a problem hiding this comment.
There is no specific error shown in logs when providing invalid field/aggregates value set as macro.
There was a problem hiding this comment.
Created a JIRA: https://cdap.atlassian.net/browse/PLUGIN-1828 to provide proper error message.
itsankit-google
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains additional scenarios for e2e coverage of groupBy plugin