Send a warning when a yaml filename has an underscore #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestSuites are grouped by test runners by the name that is generated for the tests within. To ease that grouping it is useful to have filenames with a known set of characters. Grouping is also used for py.test fixture handling. This change raises a warning if a filename has an '_' in it, effectively declaring that though it is possible to use '_', it can impact grouping. Fixes #144
|
As demonstrated by https://review.openstack.org/#/q/topic:cd/fix-gabbi-1.22 the grouping is fragile so we should do what we can to make it at least predictable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestSuites are grouped by test runners by the name that is
generated for the tests within. To ease that grouping it is
useful to have filenames with a known set of characters.
Grouping is also used for py.test fixture handling.
This change raises a warning if a filename has an '' in it,
effectively declaring that though it is possible to use '',
it can impact grouping.
Fixes #144